Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepare if dev dbt #105

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add prepare if dev dbt #105

merged 3 commits into from
Jul 12, 2024

Conversation

cnolanminich
Copy link
Contributor

Per the docs of 1.7.13:

[dagster-dbt] During development,DbtProject no longer prepares the dbt manifest file and dbt dependencies in its constructor during initialization. This process has been moved to prepare_if_dev(), that can be called on the DbtProject instance after initialization. Check out the API docs for more: https://docs.dagster.io/_apidocs/libraries/dagster-dbt#dagster_dbt.DbtProject.prepare_if_dev.

@izzye84 already did the other piece in #100, of switching the dagster-dbt CLI arguments.

This won't have an impact on branch deployments or our data-eng-prod deployment, but will be useful for local dev

Copy link

github-actions bot commented Jul 12, 2024

Your pull request at commit 31685c1da8c766cafc8f299e691bc58927eb77f4 is automatically being deployed to Dagster Cloud.

Location Status Link Updated
basics View in Cloud Jul 12, 2024 at 07:53 PM (UTC)
batch_enrichment View in Cloud Jul 12, 2024 at 07:53 PM (UTC)
data-eng-pipeline View in Cloud Jul 12, 2024 at 07:53 PM (UTC)
snowflake_insights View in Cloud Jul 12, 2024 at 07:53 PM (UTC)
demo_assets View in Cloud Jul 12, 2024 at 07:53 PM (UTC)

@izzye84
Copy link
Collaborator

izzye84 commented Jul 12, 2024

LGTM

@izzye84 izzye84 closed this Jul 12, 2024
@izzye84 izzye84 reopened this Jul 12, 2024
@cnolanminich cnolanminich merged commit 0649a95 into master Jul 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants