Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] WinTrust tests are implemented? #523

Closed
MacKey-255 opened this issue Mar 17, 2025 · 2 comments
Closed

[Question] WinTrust tests are implemented? #523

MacKey-255 opened this issue Mar 17, 2025 · 2 comments

Comments

@MacKey-255
Copy link

We currently lack tests for the WinTrust library. This makes it challenging to understand how the library is used in practice and to ensure that all functionality works as expected.

We would like to add unit tests for the WinTrust. That is possible?
This enhancement will improve reliability and help future developers quickly understand the implementation.

SAlu2s

@MacKey-255 MacKey-255 changed the title WinTrust tests [Question] WinTrust tests are implemented? Mar 17, 2025
@dahall
Copy link
Owner

dahall commented Mar 19, 2025

There is a bit of an example at https://github.com/dahall/WinClassicSamplesCS/tree/a789647b26f606fd05f2b1fc9d3b4968009eb7f7/Security/CodeSigning, but yes, that assembly deserves more unit testing.

@dahall
Copy link
Owner

dahall commented Mar 23, 2025

I added a unit test, though a little sparse.

@dahall dahall closed this as completed Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants