You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When fetching date of birth (P569) of Pythagoras (Item: Q10261) I got a DatavalueError... unsupported calendarmodel for time datavalue. Can you add/adjust the calender model to support for date of birth BCE. Many thanks.
The text was updated successfully, but these errors were encountered:
And the calendar model it refers to (Q1985786) apparently not just BCE, but Proleptic Julian calendar. It means we need to handle leap years in a different way to how Python's datetime (which assumes the current Gregorian calendar always was according to the docs) deal with them.
What I mean is not I won't implement this calendar model, but just it would take a long time. However, if somebody sends a patch to implement this I'm going to happily review it!
A workaround may be to automatically convert julian dates to gregorian dates with package https://pypi.org/project/juliandate .
Another option would be to add date decoding options in the package to keep the whole available information : time precision, calendar model, full date string...
I may propose to contribute to this work but I would prefer having maintainer's stance on the way to manage these heterogenous formats before trying to implement something...
When fetching date of birth (P569) of Pythagoras (Item: Q10261) I got a DatavalueError... unsupported calendarmodel for time datavalue. Can you add/adjust the calender model to support for date of birth BCE. Many thanks.
The text was updated successfully, but these errors were encountered: