Skip to content

Commit c78b1c2

Browse files
samtrionsamtrion
committed
fix(test): Missing testcase Azure.ServiceBus.ClientCreation 
1 parent f614c5a commit c78b1c2

File tree

1 file changed

+124
-16
lines changed

1 file changed

+124
-16
lines changed

‎tests/NetEvolve.HealthChecks.Tests.Unit/Azure/ServiceBus/ClientCreationTests.cs

Lines changed: 124 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
namespace NetEvolve.HealthChecks.Tests.Unit.Azure.ServiceBus;
22

33
using System;
4+
using System.Diagnostics;
5+
using Microsoft.Extensions.DependencyInjection;
46
using NetEvolve.Extensions.XUnit;
57
using NetEvolve.HealthChecks.Azure.ServiceBus;
68
using NSubstitute;
@@ -9,14 +11,12 @@ namespace NetEvolve.HealthChecks.Tests.Unit.Azure.ServiceBus;
911
[TestGroup($"{nameof(Azure)}.{nameof(ServiceBus)}")]
1012
public sealed class ClientCreationTests
1113
{
12-
private const string TestName = "TestName";
13-
1414
[Fact]
1515
public void GetClient_WhenModeIsConnectionString_ShouldCreateNewClient()
1616
{
1717
// Arrange
1818
const string connectionString =
19-
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=getclient-connectionstring;SharedAccessKey=testkey";
19+
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=testname;SharedAccessKey=testkey";
2020
var options = new ServiceBusQueueOptions
2121
{
2222
Mode = ClientCreationMode.ConnectionString,
@@ -25,7 +25,11 @@ public void GetClient_WhenModeIsConnectionString_ShouldCreateNewClient()
2525
var serviceProvider = Substitute.For<IServiceProvider>();
2626

2727
// Act
28-
var client = ClientCreation.GetClient(TestName, options, serviceProvider);
28+
var client = ClientCreation.GetClient(
29+
nameof(GetClient_WhenModeIsDefaultAzureCredentials_ShouldCreateNewClient),
30+
options,
31+
serviceProvider
32+
);
2933

3034
// Assert
3135
Assert.NotNull(client);
@@ -35,7 +39,7 @@ public void GetClient_WhenModeIsConnectionString_ShouldCreateNewClient()
3539
public void GetClient_WhenModeIsDefaultAzureCredentials_ShouldCreateNewClient()
3640
{
3741
// Arrange
38-
const string fullyQualifiedNamespace = "getclient-default.servicebus.windows.net";
42+
const string fullyQualifiedNamespace = "test.servicebus.windows.net";
3943
var options = new ServiceBusQueueOptions
4044
{
4145
Mode = ClientCreationMode.DefaultAzureCredentials,
@@ -44,7 +48,11 @@ public void GetClient_WhenModeIsDefaultAzureCredentials_ShouldCreateNewClient()
4448
var serviceProvider = Substitute.For<IServiceProvider>();
4549

4650
// Act
47-
var client = ClientCreation.GetClient(TestName, options, serviceProvider);
51+
var client = ClientCreation.GetClient(
52+
nameof(GetClient_WhenModeIsDefaultAzureCredentials_ShouldCreateNewClient),
53+
options,
54+
serviceProvider
55+
);
4856

4957
// Assert
5058
Assert.NotNull(client);
@@ -55,7 +63,7 @@ public void GetClient_CalledTwiceWithSameName_ShouldReturnSameInstance()
5563
{
5664
// Arrange
5765
const string connectionString =
58-
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=getclient-samename;SharedAccessKey=testkey";
66+
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=testname;SharedAccessKey=testkey";
5967
var options = new ServiceBusQueueOptions
6068
{
6169
Mode = ClientCreationMode.ConnectionString,
@@ -64,8 +72,16 @@ public void GetClient_CalledTwiceWithSameName_ShouldReturnSameInstance()
6472
var serviceProvider = Substitute.For<IServiceProvider>();
6573

6674
// Act
67-
var client1 = ClientCreation.GetClient(TestName, options, serviceProvider);
68-
var client2 = ClientCreation.GetClient(TestName, options, serviceProvider);
75+
var client1 = ClientCreation.GetClient(
76+
nameof(GetClient_CalledTwiceWithSameName_ShouldReturnSameInstance),
77+
options,
78+
serviceProvider
79+
);
80+
var client2 = ClientCreation.GetClient(
81+
nameof(GetClient_CalledTwiceWithSameName_ShouldReturnSameInstance),
82+
options,
83+
serviceProvider
84+
);
6985

7086
// Assert
7187
Assert.Same(client1, client2);
@@ -76,7 +92,7 @@ public void GetAdministrationClient_WhenModeIsConnectionString_ShouldCreateNewCl
7692
{
7793
// Arrange
7894
const string connectionString =
79-
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=getadministrationclient-connectionstring;SharedAccessKey=testkey";
95+
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=testname;SharedAccessKey=testkey";
8096
var options = new ServiceBusQueueOptions
8197
{
8298
Mode = ClientCreationMode.ConnectionString,
@@ -85,7 +101,11 @@ public void GetAdministrationClient_WhenModeIsConnectionString_ShouldCreateNewCl
85101
var serviceProvider = Substitute.For<IServiceProvider>();
86102

87103
// Act
88-
var client = ClientCreation.GetAdministrationClient(TestName, options, serviceProvider);
104+
var client = ClientCreation.GetAdministrationClient(
105+
nameof(GetAdministrationClient_WhenModeIsConnectionString_ShouldCreateNewClient),
106+
options,
107+
serviceProvider
108+
);
89109

90110
// Assert
91111
Assert.NotNull(client);
@@ -95,7 +115,7 @@ public void GetAdministrationClient_WhenModeIsConnectionString_ShouldCreateNewCl
95115
public void GetAdministrationClient_WhenModeIsDefaultAzureCredentials_ShouldCreateNewClient()
96116
{
97117
// Arrange
98-
const string fullyQualifiedNamespace = "getadministrationclient-default.servicebus.windows.net";
118+
const string fullyQualifiedNamespace = "test.servicebus.windows.net";
99119
var options = new ServiceBusQueueOptions
100120
{
101121
Mode = ClientCreationMode.DefaultAzureCredentials,
@@ -104,7 +124,11 @@ public void GetAdministrationClient_WhenModeIsDefaultAzureCredentials_ShouldCrea
104124
var serviceProvider = Substitute.For<IServiceProvider>();
105125

106126
// Act
107-
var client = ClientCreation.GetAdministrationClient(TestName, options, serviceProvider);
127+
var client = ClientCreation.GetAdministrationClient(
128+
nameof(GetAdministrationClient_WhenModeIsDefaultAzureCredentials_ShouldCreateNewClient),
129+
options,
130+
serviceProvider
131+
);
108132

109133
// Assert
110134
Assert.NotNull(client);
@@ -115,7 +139,7 @@ public void GetAdministrationClient_CalledTwiceWithSameName_ShouldReturnSameInst
115139
{
116140
// Arrange
117141
const string connectionString =
118-
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=getadministrationclient-samename;SharedAccessKey=testkey";
142+
"Endpoint=sb://test.servicebus.windows.net/;SharedAccessKeyName=testname;SharedAccessKey=testkey";
119143
var options = new ServiceBusQueueOptions
120144
{
121145
Mode = ClientCreationMode.ConnectionString,
@@ -124,10 +148,94 @@ public void GetAdministrationClient_CalledTwiceWithSameName_ShouldReturnSameInst
124148
var serviceProvider = Substitute.For<IServiceProvider>();
125149

126150
// Act
127-
var client1 = ClientCreation.GetAdministrationClient(TestName, options, serviceProvider);
128-
var client2 = ClientCreation.GetAdministrationClient(TestName, options, serviceProvider);
151+
var client1 = ClientCreation.GetAdministrationClient(
152+
nameof(GetAdministrationClient_CalledTwiceWithSameName_ShouldReturnSameInstance),
153+
options,
154+
serviceProvider
155+
);
156+
var client2 = ClientCreation.GetAdministrationClient(
157+
nameof(GetAdministrationClient_CalledTwiceWithSameName_ShouldReturnSameInstance),
158+
options,
159+
serviceProvider
160+
);
129161

130162
// Assert
131163
Assert.Same(client1, client2);
132164
}
165+
166+
[Fact]
167+
public void GetClient_WhenModeIsInvalid_ShouldThrowUnreachableException()
168+
{
169+
// Arrange
170+
var options = new ServiceBusQueueOptions { Mode = (ClientCreationMode)int.MaxValue };
171+
var serviceProvider = Substitute.For<IServiceProvider>();
172+
173+
// Act
174+
void Act() =>
175+
ClientCreation.GetClient(
176+
nameof(GetClient_WhenModeIsInvalid_ShouldThrowUnreachableException),
177+
options,
178+
serviceProvider
179+
);
180+
181+
// Assert
182+
_ = Assert.Throws<UnreachableException>(Act);
183+
}
184+
185+
[Fact]
186+
public void GetAdministrationClient_WhenModeIsInvalid_ShouldThrowUnreachableException()
187+
{
188+
// Arrange
189+
var options = new ServiceBusQueueOptions { Mode = (ClientCreationMode)int.MaxValue };
190+
var serviceProvider = Substitute.For<IServiceProvider>();
191+
192+
// Act
193+
void Act() =>
194+
ClientCreation.GetAdministrationClient(
195+
nameof(GetAdministrationClient_WhenModeIsInvalid_ShouldThrowUnreachableException),
196+
options,
197+
serviceProvider
198+
);
199+
200+
// Assert
201+
_ = Assert.Throws<UnreachableException>(Act);
202+
}
203+
204+
[Fact]
205+
public void GetClient_WhenServiceProviderIsNull_ShouldThrowInvalidOperationException()
206+
{
207+
// Arrange
208+
var options = new ServiceBusQueueOptions { Mode = ClientCreationMode.ServiceProvider };
209+
var serviceProvider = new ServiceCollection().BuildServiceProvider();
210+
211+
// Act
212+
void Act() =>
213+
ClientCreation.GetClient(
214+
nameof(GetClient_WhenServiceProviderIsNull_ShouldThrowInvalidOperationException),
215+
options,
216+
serviceProvider
217+
);
218+
219+
// Assert
220+
_ = Assert.Throws<InvalidOperationException>(Act);
221+
}
222+
223+
[Fact]
224+
public void GetAdministrationClient_WhenServiceProviderIsNull_ShouldThrowInvalidOperationException()
225+
{
226+
// Arrange
227+
var options = new ServiceBusQueueOptions { Mode = ClientCreationMode.ServiceProvider };
228+
var serviceProvider = new ServiceCollection().BuildServiceProvider();
229+
230+
// Act
231+
void Act() =>
232+
ClientCreation.GetAdministrationClient(
233+
nameof(GetAdministrationClient_WhenServiceProviderIsNull_ShouldThrowInvalidOperationException),
234+
options,
235+
serviceProvider
236+
);
237+
238+
// Assert
239+
_ = Assert.Throws<InvalidOperationException>(Act);
240+
}
133241
}

0 commit comments

Comments
 (0)