Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link preview localization #1279

Open
dcposch opened this issue Aug 19, 2024 · 0 comments
Open

Link preview localization #1279

dcposch opened this issue Aug 19, 2024 · 0 comments

Comments

@dcposch
Copy link
Member

dcposch commented Aug 19, 2024

Summary

Follow-up to #1243

Turns out Telegram, Signal & probably others request link previews with Accept-Language: en-US even when the requesting app is set to Spanish.

This means link previews currently always display in English.

Proposed fix

Add an &l=es, etc to the end of generated links. This is still imperfect: the link preview will show the language of whoever generated the link, not whoever is about to click the link. But I think it's the best we can do given the messaging apps' behavior.

Apps probably request previews this way so that they can cache a single preview per URL, rather than one per (URL, viewer langage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant