Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-audit checklist #1

Closed
8 tasks done
dcposch opened this issue Aug 14, 2023 · 2 comments
Closed
8 tasks done

Pre-audit checklist #1

dcposch opened this issue Aug 14, 2023 · 2 comments

Comments

@dcposch
Copy link
Member

dcposch commented Aug 14, 2023 •
edited by nalinbhardwaj
Loading

  • Remove all commented-out code from P256Verifier.
  • Clean up code, add thorough inline documentation.
  • Remove reverts. EIP-7212 spec always returns 1 or 0, never reverts.
  • Combine test vectors in a clean JSON file. Use in forge test.
    • Wycheproof vectors
    • Sage vectors
    • others?
  • Measure branch coverage
  • Measure gas cost
  • Deploy on Base Goerli
  • Test in Daimo via 4337 contract account
@dcposch
Copy link
Member Author

dcposch commented Aug 16, 2023

  • Potentially formal verification. Will talk to Veridise

@nalinbhardwaj
Copy link
Member

Audit is complete #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcposch @nalinbhardwaj