Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 0.0.0.0 instead of 127.0.0.1 for -Dorg.daisy.pipeline.ws.host #256

Open
bertfrees opened this issue Nov 11, 2024 · 4 comments
Open

Use 0.0.0.0 instead of 127.0.0.1 for -Dorg.daisy.pipeline.ws.host #256

bertfrees opened this issue Nov 11, 2024 · 4 comments
Milestone

Comments

@bertfrees
Copy link
Member

This would allow me to connect from another machine to the app's internal web server.

@bertfrees
Copy link
Member Author

Can this be done? It's a simple change. I can make a PR if needed.

@marisademeglio
Copy link
Member

Sure we can do that

@marisademeglio marisademeglio added this to the 1.8 milestone Feb 13, 2025
@NPavie
Copy link
Collaborator

NPavie commented Feb 14, 2025

Hum, I just tested the switch to 0.0.0.0 on the dev side, and this made the app raise a system event : my windows request if i authorize the app to be accessible from other networks and if I want to create a rule on the firewall.
Note that creation of the rule in the firewall requires admin rights.

(This can be ditched but users might be surprised at first, we might need to warn users)

Just in case, @bertfrees can you test something on your current install ?
Can you open the settings file and change the field webservice.host to 0.0.0.0 and restart the app ?
(From the code, it should launch the daisy-pipeline on 0.0.0.0)

@bertfrees
Copy link
Member Author

@NPavie That works! And I'm not getting any system prompts.

For me this is sufficient. I can go into the settings and change this line. It doesn't need to be the default, and there's no need for a setting in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants