writeCollection: Wait until previous invocation finished #157
Conversation
This commit changes how writeCollection works. Previously, it seemed to be a forced delay of some number of milliseconds that would need to happen before a call to ddcutil to change brightness could occur. Update to use a simpler logic: No more delays. If a ddcutil set brightness command is running, queue the next command that's generated and run it immediately after the first command completes. If a command is queued and another one comes in, the newest one replaces the queued one, becoming the only queued one. This patch is a draft. If this concept is acceptable, a futher update would be needed to remove the concept of writeCollectorWaitMs. Alternatively, we could keep the concept and mandate a minimum interval between two invocationsn of ddcutil, either measured from start time to start time, or end time to start time.
|
Sorry if it's not clear. This is a draft and not ready to merge just yet. Feedback appreciated. Thanks! |
|
Have you tried tweaking your ddcutil options with Sleep multiplier and Queue ms, which are available from this extension's settings? |
Hey, I just did on your recommendation. Looks like I need to set it 250ms or higher and indeed my problems are solved, except for a minor annoyance. The minor annoyance is that the current code will keep a 250ms delay (in my case) before any adjustments, even if it hasn't run ddcutil in a while. It seems like it would be nice to not need that delay. I also don't know about others setups, but if ensuring one invocation completes before the next begins means that users don't need to worry about Queue ms in the settings, that seems like a win. I'm happy to take a pass at optimizing here, but let me know your opinion on the above before I spend too many cycles on it. Thanks very much! |
|
I just tried it, no change in behavior. I think these are addressing different issues, though. #108 PR seems to be a change in how displays are detected. My proposed change is only related to updating brightness, esp multiple changes in rapid succession (e.g. from hitting the brightness up button multiple times). |
Hi, Please take a look at the commit, "DRAFT: writeCollection: Wait until previous invocation finished"
I would appreciate feedback and would be happy to take another pass based on any feedback you give.
This fixes #158 for me.
Thanks very much!