Merge pull request #19 from patika-hepsiburada-react-bootcamp/dev

[#17] refactor: refactor done on controllers

Author: damla

server/app.js

@@ -13,7 +13,7 @@ connectToDb();
 const app = express();
 app.use(cors());
 app.use(bodyParser.json());
-app.use(bodyParser.urlencoded({ extended: true }));
+app.use(bodyParser.urlencoded({ extended: false }));
 
 app.use("/products", products);
 app.use("/colors", colors);

server/controllers/brands.controller.js

@@ -5,19 +5,28 @@ const controller = {};
 
 controller.getAll = async (req, res) => {
   try {
-    let data = await client.get("brans");
+    // check if data exist in memory cache
+    let data = await client.get("brands");
+    let cachedData = JSON.parse(data);
 
-    if (data) res.status(200).send(data);
-    else {
-      let brandData = await Brand.getAll();
+    // if data exist, send it as a response
+    if (cachedData) {
+      if (cachedData <= 0) res.status(404).json("Brands data does not exist.");
+      res.status(200).json(cachedData);
+    } else {
+      // pull data from db
+      let brands = await Brand.getAll();
 
-      await client.set("brands", JSON.stringify({ ...brandData }));
-      let brands = await client.get("brands");
-      res.status(200).send(JSON.parse(brands));
+      // cache the data
+      await client.set("brands", JSON.stringify(brands));
+
+      // send data pulled from db
+      if (brands <= 0) res.status(404).json("Brands data does not exist.");
+      res.status(200).json(brands);
     }
   } catch (err) {
-    console.log("Error in getting product- " + err);
-    res.status(500).end("error");
+    console.error("Error in getting brands data - " + err.message);
+    res.status(500).json({ error: "Got error in getAll controller of brands" });
   }
 };
 export default controller;

server/controllers/colors.controller.js

@@ -5,19 +5,29 @@ const controller = {};
 
 controller.getAll = async (req, res) => {
   try {
+    // check if data exist in memory cache
     let data = await client.get("colors");
+    let cachedData = JSON.parse(data);
 
-    if (data) res.status(200).send(data);
-    else {
-      let colorData = await Color.getAll();
+    // if data exist, send it as a response
+    if (cachedData) {
+      if (cachedData <= 0) res.status(404).json("Colors data does not exist.");
+      res.status(200).json(cachedData);
+    } else {
+      // pull data from db
+      let colors = await Color.getAll();
 
-      await client.set("colors", JSON.stringify({ ...colorData }));
-      let colors = await client.get("colors");
-      res.status(200).send(JSON.parse(colors));
+      // cache the data
+      await client.set("colors", JSON.stringify(colors));
+
+      // send data pulled from db
+      if (colors <= 0) res.status(404).json("Colors data does not exist.");
+      res.status(200).json(colors);
     }
   } catch (err) {
-    console.log("Error in getting product- " + err);
-    res.status(500).end("Got error in getAll");
+    console.error("Error in getting colors data - " + err.message);
+    res.status(500).json({ error: "Got error in getAll controller of colors" });
   }
 };
+
 export default controller;

server/controllers/products.controller.js

@@ -5,19 +5,31 @@ const controller = {};
 
 controller.getAll = async (req, res) => {
   try {
+    // check if data exist in memory cache
     let data = await client.get("products");
-
-    if (data) res.status(200).send(data);
-    else {
-      let productData = await Product.getAll();
-
-      await client.set("products", JSON.stringify({ ...productData }));
-      let products = await client.get("products");
-      res.status(200).send(JSON.parse(products));
+    let cachedData = JSON.parse(data);
+
+    // if data exist, send it as a response
+    if (cachedData) {
+      if (cachedData <= 0)
+        res.status(404).json("Products data does not exist.");
+      res.status(200).json(cachedData);
+    } else {
+      // pull data from db
+      let products = await Product.getAll();
+
+      // cache the data
+      await client.set("products", JSON.stringify(products));
+
+      // send data pulled from db
+      if (products <= 0) res.status(404).json("Products data does not exist.");
+      res.status(200).json(products);
     }
   } catch (err) {
-    console.log("Error in getting product- " + err);
-    res.status(500).send("Got error in getAll");
+    console.error("Error in getting products data - " + err.message);
+    res
+      .status(500)
+      .json({ error: "Got error in getAll controller of products" });
   }
 };
 

server/models/brands.model.js

@@ -2,9 +2,9 @@ import mongoose from "mongoose";
 
 const BrandSchema = mongoose.Schema(
   {
-    _id: mongoose.Schema.ObjectId,
+    _id: mongoose.Schema.Types.ObjectId,
     name: String,
-    price: [mongoose.Schema.ObjectId],
+    products: [{ type: mongoose.Schema.Types.ObjectId, ref: "products" }],
   },
   { collection: "brand" }
 );

server/models/colors.model.js

@@ -2,9 +2,9 @@ import mongoose from "mongoose";
 
 const ColorSchema = mongoose.Schema(
   {
-    _id: mongoose.Schema.ObjectId,
+    _id: mongoose.Schema.Types.ObjectId,
     name: String,
-    price: [mongoose.Schema.ObjectId],
+    products: [{ type: mongoose.Schema.Types.ObjectId, ref: "products" }],
   },
   { collection: "color" }
 );

server/models/products.model.js

@@ -2,12 +2,12 @@ import mongoose from "mongoose";
 
 const ProductSchema = mongoose.Schema(
   {
-    _id: mongoose.Schema.ObjectId,
+    _id: mongoose.Schema.Types.ObjectId,
     name: String,
     color: String,
     brand: String,
     price: {
-      base: mongoose.Decimal128,
+      base: mongoose.Number,
       discountAmount: Number,
     },
     createdAt: Date,
@@ -23,7 +23,7 @@ ProductsModel.getById = async (id) => {
 };
 
 ProductsModel.getAll = async () => {
-  return ProductsModel.find({});
+  return ProductsModel.find();
 };
 
 export default ProductsModel;