-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
See highlighted segments on kind1 notes #1772
Comments
@jb55 - @ericholguin is asking if reading highlights on Damus is planned. I support adding this feature - as we discussed today my view is that interoperability is the key to Damus, and nostr winning. Three questions: Are you onboard with see note highlights in Damus? |
I'm ok with it but when it gets to longform highlights it can get pretty complex pretty quickly. simple web highlights would be great. |
closed duplicate here: #2110 updated user story |
This patch adds highlights (NIP-84) to Damus. Kind 9802 are handled by all the necessary models. We show highlighted events, longform events, and url references. Url references also leverage text fragments to take the user to the highlighted text. Testing —— iPhone 15 Pro Max (17.0) Dark Mode: https://v.nostr.build/oM6DW.mp4 iPhone 15 Pro Max (17.0) Light Mode: https://v.nostr.build/BRrmP.mp4 iPhone SE (3rd generation) (16.4) Light Mode: https://v.nostr.build/6GzKa.mp4 —— Closes: damus-io#2172 Closes: damus-io#1772 Closes: damus-io#1773 Closes: damus-io#2173 Closes: damus-io#2175 Changelog-Added: Highlights (NIP-84) PATCH CHANGELOG: V1 -> V2: addressed review comments highlights are now truncated and highlight label shown in Thread view Signed-off-by: ericholguin <[email protected]>
user story
As a Damus user who is seeking signal, I want to be able to see highlights of my WOT, so that I can find and read what others think provides the most signal.
acceptance criteria
@ericholguin has a PR on his branch
video in note below:
https://damus.io/note1sm6e6v4uz6mr6kth4faze8mlj54353lzzcy09qt552ytatxj38kq8l7cnc
https://njump.me/note1sm6e6v4uz6mr6kth4faze8mlj54353lzzcy09qt552ytatxj38kq8l7cnc
implementation
NIP-84
related to
create highlights #822
see long form highlights #1773
The text was updated successfully, but these errors were encountered: