Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DamusState::NewTimelineSub FilterState #359

Closed
jb55 opened this issue Oct 17, 2024 · 1 comment · Fixed by #439
Closed

Fix DamusState::NewTimelineSub FilterState #359

jb55 opened this issue Oct 17, 2024 · 1 comment · Fixed by #439
Assignees
@jb55
Milestone
notedeck alpha

Comments

@jb55
Copy link
Contributor

jb55 commented Oct 17, 2024

This probably shouldn't even be a state on damus state, because there could be more than one column that needs contact lists to be fetched. Right now this state is only handling when the FilterState is Ready which is incorrect an gets stuck in a loop.
@jb55 jb55 self-assigned this Oct 17, 2024
@jb55 jb55 added this to the notedeck alpha milestone Oct 17, 2024
@jb55 jb55 moved this to In Progress in Damus Roadmap 🛣️ Oct 17, 2024
@jb55
Copy link
Contributor Author

jb55 commented Oct 23, 2024

Should be fixed in

@jb55 jb55 mentioned this issue Nov 14, 2024
Closed
@jb55 jb55 mentioned this issue Nov 14, 2024
Merged
@jb55 jb55 closed this as completed in 01bedac Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jb55 jb55

Labels
None yet
Projects
Damus Roadmap 🛣️
Archived in project
Milestone
notedeck alpha
Development

Successfully merging a pull request may close this issue.

Fix new timelines with non-ready filter states damus-io/notedeck
1 participant
@jb55