Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neovim support #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

glostis
Copy link

@glostis glostis commented Jan 6, 2025

Closes #28 by adding a class Neovim which inherits from Vim (since both editors share the same file opening syntax).

@glostis glostis mentioned this pull request Jan 6, 2025
@dandavison
Copy link
Owner

Thanks! Would you mind copying your changes to the other copy of the script at https://github.com/dandavison/open-in-editor/blob/master/OpenInEditor.app/Contents/Resources/script ?

I know... !

@glostis
Copy link
Author

glostis commented Jan 6, 2025

@dandavison sure I can do that, no problem!
As an alternative, did you consider making OpenInEditor.app/Contents/Resources/script a symlink to open-in-editor? That way, they would always be in sync.

@dandavison
Copy link
Owner

As an alternative, did you consider making OpenInEditor.app/Contents/Resources/script a symlink to open-in-editor? That way, they would always be in sync.

I did -- IIRC that doesn't obviously play well with the MacOS app bundle installation at https://github.com/dandavison/open-in-editor?tab=readme-ov-file#macos, I think it would need some sort of build step, but I was trying to keep this all very simple.

@glostis
Copy link
Author

glostis commented Jan 6, 2025

Understood — symlinks can cause some problems at times indeed.

I’ve pushed the change to the other script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvim support?
2 participants