-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q: provide /server-info "natively" (or redirected to) by web service? #1108
Comments
@yarikoptic, do you know why we need this top-level URL at all? This simply redirects (in the case of the production instance) to https://api.dandiarchive.org/api/info/. If it is because there is some bootstrapping needed to know that the API is served from Thoughts? |
The point of having each DANDI instance (be it main deployment, or staging, or my lab's, or some test docker) to provide edit: note - users should not know about existence of some separate API server |
Note: As the extended description of the #1190 says that PR added |
If you could add the trailing slash in the CLI, that would be great, because it would solve your problem in the short term. I know that we are in the middle of discussing this in #1200, but I think the solution proposed in that issue is the correct solution here, and will obviate the need to worry about trailing slashes altogether. |
🚀 Issue was released in |
@waxlamp @AlmightyYakob Was this PR reverted/undone at some point? Currently, making a request to a Dockerized API instance at |
|
ATM it is handled via redirect on netlify level
dandi-archive/web/netlify/plugins/server-info-build/index.js
Line 10 in 12e1c5e
so it is not available in docker-compose'd instance of the archive, thus no other but the netlify instances would have it. But dandi-cli uses
/server-info
to identify the actual endpoints for e.g. API service etc, so that is what it accesses whenever given some URL. So it would be nice to have that endpoint also for docker-compose instances. We have been relying on redirector before, so was tested and now we need to adjust the test dandi/dandi-cli#977 accordingly but there is no such endpoint in docker-compose setup.The text was updated successfully, but these errors were encountered: