Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Metadata Specification Broke dandiset/my Request #1769

Closed
garrettmflynn opened this issue Nov 30, 2023 · 6 comments · Fixed by #1771
Closed

Incorrect Metadata Specification Broke dandiset/my Request #1769

garrettmflynn opened this issue Nov 30, 2023 · 6 comments · Fixed by #1771
Assignees
Labels
bug Something isn't working released This issue/pull request has been released.

Comments

@garrettmflynn
Copy link

Related to #1640, I've been using a custom JavaScript API to make POST requests to create new Dandisets. However, I recently specified contributor as a dictionary rather than a list on a new Dandiset I was trying to set to be embargoed—resulting in the inability to make a request to https://gui-staging.dandiarchive.org/dandiset/my.

Screenshot 2023-11-30 at 2 25 45 PM

Because of this, I have no way to personally manage the issue—and, in fact, I don't even know the Dandiset ID for the problem Dandiset ("Embargo Test" as a title)

Beyond this personal problem, this points to a general issue coming from a (seeming) reliance on client-side validation—usually handled by the Python CLI—to ensure that DANDI receives the appropriate metadata to complete a Dandiset. Although it didn't break anything, I was also able to specify an invalid License field as well as create dandisets with only a Title using my JS API.

@mvandenburgh
Copy link
Member

@garrettmflynn thanks for the bug report. This does indeed look like a bug in our code as a result of us making certain assumptions about the JSON metadata structure. I'll get a fix in for that. In the meantime, I've removed you as an owner of that dandiset so that your "My Dandisets" page won't crash anymore.

@garrettmflynn
Copy link
Author

Hmm "My Dandisets" is still down for me. Additional issues might have been introduced in one or two subsequent dandisets with Embargo in the title too.

@dandibot
Copy link
Member

dandibot commented Dec 1, 2023

🚀 Issue was released in v0.3.66 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Dec 1, 2023
@garrettmflynn
Copy link
Author

@mvandenburgh Still getting the same error. Do I have to wait for any server restarts?

@mvandenburgh
Copy link
Member

@mvandenburgh Still getting the same error. Do I have to wait for any server restarts?

Yes, the deployment usually takes a few minutes. I just checked and it finished a few seconds ago, so can you try that page again?

@garrettmflynn
Copy link
Author

Got it. Can confirm it's working!

Test Embargo is still showing up on my list and will throw an error if I navigate to it—but maybe this is unavoidable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants