Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI can't read GitHub Actions secrets on fork-based PRs #2107

Closed
mvandenburgh opened this issue Dec 11, 2024 · 0 comments · Fixed by #2118
Closed

CI can't read GitHub Actions secrets on fork-based PRs #2107

mvandenburgh opened this issue Dec 11, 2024 · 0 comments · Fixed by #2118

Comments

@mvandenburgh
Copy link
Member

Example: #2105

Because that PR was based on a fork of dandi-archive, and not a branch internal to the dandi/dandi-archive repo, the DOCKER_LOGIN and DOCKER_TOKEN GitHub Actions secrets could not be read due to permission issues.
@mvandenburgh mvandenburgh mentioned this issue Dec 19, 2024
Merged
yarikoptic added a commit to yarikoptic/dandi-archive that referenced this issue Dec 19, 2024
@yarikoptic
Login to docker hub only if credentials were provided
1de57d7 
I think this could be the only solution (may be besides also adding retries in addition)
to allow testing against dandi-cli to be done also in PRs from forks of the project,
where there is no credentials.  We could also advise our developers to provide such (own)
credentials in their forks.

FTR: login originally was added in 6b815dc

ref: dandi#2107
yarikoptic added a commit to yarikoptic/dandi-archive that referenced this issue Dec 19, 2024
@yarikoptic
Login to docker hub only if credentials were provided
dbfd189 
I think this could be the only solution (may be besides also adding retries in addition)
to allow testing against dandi-cli to be done also in PRs from forks of the project,
where there is no credentials.  We could also advise our developers to provide such (own)
credentials in their forks.

FTR: login originally was added in 6b815dc

ref: dandi#2107
@yarikoptic yarikoptic mentioned this issue Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Login to docker hub only if credentials were provided yarikoptic/dandi-archive
1 participant
@mvandenburgh