Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more maintainers #1162

Open
paroj opened this issue Apr 1, 2024 · 6 comments
Open

add more maintainers #1162

paroj opened this issue Apr 1, 2024 · 6 comments

Comments

@paroj
Copy link
Contributor

paroj commented Apr 1, 2024

the current xz utils situation inspired me to pressure you to add additional maintainers to this repo, so things get moving again. Lets say @flyingOwl

@flyingOwl
Copy link
Contributor

I mean, jokes aside... This project really needs a little push. I know a few people who use DSub regularly and they all complain about minor inconveniences. Those things could have already been fixed as some of them have pending pull requests or are part of forks. I use DSub because it handles music and the connection to my setup the way I want. And with some changes and bug fixes, it would be perfect and probably more attractive to others. Having a manually build fork that is a dozen commits ahead just feels wrong.

@paroj
Copy link
Contributor Author

paroj commented Apr 3, 2024

maybe we can start by unifying our own forks into one with the main goal of collecting bugfixes and keeping the code buildable with a recent android studio so people can easily contribute.
I have integrated your pull requests into my fork in #1126 and added some more fixes over the holidays. We could start with that.
Additionally I would make ServerProxy an inline copy instead of a submodule to simplify updating, while keeping both repos in sync. I dont think it is used outside of DSub anyway..

I would call the fork DSub2000 to clearly mark it as a fork and hope that we can merge the changes back here one day. That would be the best outcome so the changes arrive as an update to existing users at some point.

If you agree, I can go ahead and create such a repo and add you as a maintainer.

@flyingOwl
Copy link
Contributor

That would be awesome. Let's do this!

I also have a few more features in my fork and my local copy (still uncommited). But it will probably take a week or two until I can get my hands on the code again.

@norohind
Copy link

norohind commented Apr 6, 2024

Greetings. I'm also interested in contributing small fixes for problems that annoy me daily.
Paroj, could you please open issues section in your fork so we can discuss fork related stuff there?

@paroj
Copy link
Contributor Author

paroj commented Apr 6, 2024

done. this is the fork for reference: https://github.com/paroj/DSub2000

@gravelld
Copy link

gravelld commented Apr 8, 2024

It might also be time to support the new Open Subsonic spec... https://github.com/opensubsonic/open-subsonic-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants