multiplane_convergence in utilities #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accidentally uploaded and deleted a zip file, so disregard the first two commits. |
hi @BirendraDh , if that is the case, then you have the option of changing either the size of the convergence map or the size of the lensed image, and that functionality I thiink is already implemented. I don't think this warrants a pull request to change the multiplane_convergence function, which is doing what it's supposed to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dangilman A kappa map generated by the multiplane_convergence imported from pyHalo.utilities is twice as big as the lensed picture. This choice, in my opinion, lengthens the computation of correlation by at least four times. To fix this, I modified multiplane_convergence function in pyHalo.utilities.