From 80939e74ef4b5b2fc2c5dbb9ea30d2478d523b9c Mon Sep 17 00:00:00 2001 From: Dan Redding <125183946+dangotbanned@users.noreply.github.com> Date: Fri, 19 Jul 2024 15:43:20 +0100 Subject: [PATCH] test: skip `ibis` test on unsupported `python` version (#3486) * test: skip `ibis` test on unsupported `python` version Always was emitting the same warning on `3.8`, `3.9`: ``` ================================================================================================= warnings summary ================================================================================================= tests/vegalite/v5/test_api.py::test_ibis_with_date_32 /altair/altair/vegalite/v5/api.py:233: UserWarning: data of type not recognized warnings.warn(f"data of type {type(data)} not recognized", stacklevel=1) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ==================================================================================== 210 passed, 1 xfailed, 1 warning in 17.92s ==================================================================================== ``` * test: lower the minimum `python` 3.10 -> 3.9 for `ibis` https://github.com/vega/altair/pull/3486#issuecomment-2239254956 --- tests/vegalite/v5/test_api.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/vegalite/v5/test_api.py b/tests/vegalite/v5/test_api.py index 990e0965c..8052c7a65 100644 --- a/tests/vegalite/v5/test_api.py +++ b/tests/vegalite/v5/test_api.py @@ -1526,6 +1526,11 @@ def test_polars_with_pandas_nor_pyarrow(monkeypatch: pytest.MonkeyPatch): assert "numpy" not in sys.modules +@pytest.mark.skipif( + sys.version_info < (3, 9), + reason="The maximum `ibis` version installable on Python 3.8 is `ibis==5.1.0`," + " which doesn't support the dataframe interchange protocol.", +) @pytest.mark.skipif( Version("1.5") > PANDAS_VERSION, reason="A warning is thrown on old pandas versions",