Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to plot just the data (without the model fit) in bubble_plot() #50

Open
befriendabacterium opened this issue Sep 18, 2023 · 2 comments

Comments

@befriendabacterium
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Good to have this option so can easily produce equivalent plots without model fit, especially where a model wasn't fit/able to be fit/was poor/non-sig for certain subsets of the data you're presenting, and you therefore may not want to show the model fit on some plots.

Describe the solution you'd like
Option to provide a dataframe as bubble_plot()'s 'object' argument, and it to plot without this.

Describe alternatives you've considered
Could remove model fits manually via +'ing a ggplot line maybe? But doesn't solve issue where I model wasn't fit/couldn't be fit (since there's no model object to fit).

Additional context
I already made some preliminary edits to bubble_plot() to solve this, just making this feature request for housekeeping purposes/in case edits are needed.

@befriendabacterium
Copy link
Contributor Author

Here's my proposed solution...https://github.com/befriendabacterium/orchaRd/tree/justdata

@befriendabacterium
Copy link
Contributor Author

befriendabacterium commented Sep 18, 2023

And pull request for it...though might be a bit early as quite a few edits i've made and you'll likely want to review for style and do a bit more robustness testing. Let me know if you need a hand! #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant