-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain plant pictures when updating cover picture #312
Comments
This might still need some work. I took a new picture and it saved two copies of the old pic to the gallery. I went to delete one and it started giving me 500 errors because it could not find that picture anymore. |
Do you know what steps you went through when that happened? Seems very odd
and we haven't been encountering this bug so far. What does the 500 error
say exactly? In theory I imagine that the request would be issued twice per
session, like performing the POST request, then refresh the current
request, so it issues it again and thus resulting - in a bad coincidence -
in a duplicate entry. As a small fix I'll add that there is a check first
when displaying gallery images so it will not result in a 500 in case an
image does not exist on disk/volume.
|
I don't have the error anymore, but it basically was freaking out because it could not find the duplicate image anymore. I think the delete option didn't remove all references to the image which spawned the error. |
Description of your request
When adding or updating the plant picture, rather than replacing the current picture (the current behaviour) could the picture be transferred to the gallery instead - so a history of the plants progress can be kept? each picture adds to the gallery, which can be deleted manually, rather than automatically. Possibly, an option can be given to replace or add as the user desires.
Describe alternatives you've considered
The only current alternative that I can imagine is to download the current plant picture, then upload it to the plant gallery manually then upload a new plant cover image.
Additional context

Ideally the most recent picture would become the cover photo for the plant - and as such would be more recognisable than a (possibly) months old picture
In this image adding a new image via [1] would add the current picture to the "Photos" Gallery, instead of having to download and then manually upload to [2]
The text was updated successfully, but these errors were encountered: