Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain plant pictures when updating cover picture #312

Open
dghoti opened this issue Nov 30, 2024 · 6 comments
Open

Retain plant pictures when updating cover picture #312

dghoti opened this issue Nov 30, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request improvement Improve an existing feature

Comments

@dghoti
Copy link

dghoti commented Nov 30, 2024

Description of your request
When adding or updating the plant picture, rather than replacing the current picture (the current behaviour) could the picture be transferred to the gallery instead - so a history of the plants progress can be kept? each picture adds to the gallery, which can be deleted manually, rather than automatically. Possibly, an option can be given to replace or add as the user desires.

Describe alternatives you've considered
The only current alternative that I can imagine is to download the current plant picture, then upload it to the plant gallery manually then upload a new plant cover image.

Additional context
Ideally the most recent picture would become the cover photo for the plant - and as such would be more recognisable than a (possibly) months old picture
image
In this image adding a new image via [1] would add the current picture to the "Photos" Gallery, instead of having to download and then manually upload to [2]

@dghoti dghoti added enhancement New feature or request improvement Improve an existing feature labels Nov 30, 2024
@danielbrendel danielbrendel self-assigned this Dec 3, 2024
danielbrendel added a commit that referenced this issue Dec 3, 2024
danielbrendel added a commit that referenced this issue Dec 3, 2024
danielbrendel added a commit that referenced this issue Dec 3, 2024
danielbrendel added a commit that referenced this issue Dec 5, 2024
@dghoti
Copy link
Author

dghoti commented Dec 5, 2024

This is a great improvement, thank you!
image

I am being fussy here, but is there a way to make this ticked by default (or user configurable?) - but this is a fantastic time saver and extremely superior! Thank you for adding this!

@dghoti
Copy link
Author

dghoti commented Dec 5, 2024

having used it a few times - maybe retain the original upload time, rather than use the "replacement time"
image
As you can see, the original photo was uploaded 24 th November, when the plant was added, but having been replaced with a new cover photo, it now shows creation time of only a few hours, instead of several weeks.. (still a fantacstic feature though!)

@kaleben0
Copy link

This might still need some work. I took a new picture and it saved two copies of the old pic to the gallery. I went to delete one and it started giving me 500 errors because it could not find that picture anymore.
Restored the database from last night's backups, and it is fine now.

@danielbrendel
Copy link
Owner

danielbrendel commented Dec 12, 2024 via email

@kaleben0
Copy link

I don't have the error anymore, but it basically was freaking out because it could not find the duplicate image anymore. I think the delete option didn't remove all references to the image which spawned the error.
I tried going into the database and removing the reference manually, but that didn't work either.

danielbrendel added a commit that referenced this issue Dec 15, 2024
danielbrendel added a commit that referenced this issue Dec 15, 2024
@danielbrendel
Copy link
Owner

@dghoti you're right, that would be better for organizing.

@kaleben0 I updated it so that when a gallery asset is nonexistent then the system will display the placeholder instead, so no error 500 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement Improve an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants