From 579a462cc9e77a9d9f3388fb8b1ff9043db7ccdd Mon Sep 17 00:00:00 2001 From: Daniel Chalmers Date: Wed, 31 Jan 2024 19:11:38 -0600 Subject: [PATCH] Revert "Show in-app rating prompt" This reverts commit e4d9d6519daa6a864da24ea8efbf9a48ce84a763. This library does not correctly support .NET 8 yet, but a commit has been pushed for that very thing https://github.com/FabriBertani/Plugin.Maui.AppRating/commit/72b99a42f1ab25c09168dfc9b3c21f208490bbc6 so we just need to wait and then we'll be able to merge this again --- JournalApp/App.xaml.cs | 2 +- JournalApp/Components/Pages/Index.razor | 4 --- JournalApp/Data/AppRatingService.cs | 46 ------------------------- JournalApp/JournalApp.csproj | 1 - JournalApp/MauiProgram.cs | 3 -- JournalApp/Resources/Raw/Credits.txt | 25 -------------- 6 files changed, 1 insertion(+), 80 deletions(-) delete mode 100644 JournalApp/Data/AppRatingService.cs diff --git a/JournalApp/App.xaml.cs b/JournalApp/App.xaml.cs index 7fe793d..12c93df 100644 --- a/JournalApp/App.xaml.cs +++ b/JournalApp/App.xaml.cs @@ -17,7 +17,7 @@ public App() public static (DateTimeOffset LeftAt, DateOnly LastDate)? IndexDateState { get; set; } - public static int LaunchCount + public int LaunchCount { get => Preferences.Get("launches", 0); set => Preferences.Set("launches", value); diff --git a/JournalApp/Components/Pages/Index.razor b/JournalApp/Components/Pages/Index.razor index ca16e53..eaf85cb 100644 --- a/JournalApp/Components/Pages/Index.razor +++ b/JournalApp/Components/Pages/Index.razor @@ -10,7 +10,6 @@ @inject KeyEventService KeyEventService @inject NavigationManager NavigationManager @inject IScrollManager ScrollManager -@inject AppRatingService AppRatingService
@@ -292,9 +291,6 @@ logger.LogInformation("Saving new note"); note.Category.Points.Add(note); await db.SaveChangesAsync(); - - // Better to ask for a rating after a pleasant event like finishing a note than obstructively like on launch. - await AppRatingService.TryShowInAppRatingDialog(); } ValueTask OnLocationChanging(LocationChangingContext e) diff --git a/JournalApp/Data/AppRatingService.cs b/JournalApp/Data/AppRatingService.cs deleted file mode 100644 index 39e392c..0000000 --- a/JournalApp/Data/AppRatingService.cs +++ /dev/null @@ -1,46 +0,0 @@ -using Plugin.Maui.AppRating; - -namespace JournalApp; - -public class AppRatingService(ILogger logger, IAppRating appRating) -{ - public async Task TryShowInAppRatingDialog() - { - if (!OperatingSystem.IsAndroid()) - { - logger.LogDebug("Not on Android"); - return; - } - - if (App.LaunchCount < 20 || LastRatingDate + TimeSpan.FromDays(90) > DateTimeOffset.Now) - { - logger.LogDebug("Too soon"); - return; - } - - logger.LogInformation("Showing in-app rating prompt"); - LastRatingDate = DateTimeOffset.Now; - - // Doesn't do anything unless installed from the Play Store. - await appRating.PerformInAppRateAsync(); - } - - private DateTimeOffset LastRatingDate - { - get - { - var lastExportString = Preferences.Get("last_rating", null); - - if (DateTimeOffset.TryParse(lastExportString, out var parsed)) - { - return parsed; - } - else - { - LastRatingDate = default; - return default; - } - } - set => Preferences.Set("last_rating", value.ToString("O")); - } -} diff --git a/JournalApp/JournalApp.csproj b/JournalApp/JournalApp.csproj index 20ba37b..bcc89c6 100644 --- a/JournalApp/JournalApp.csproj +++ b/JournalApp/JournalApp.csproj @@ -62,7 +62,6 @@ - \ No newline at end of file diff --git a/JournalApp/MauiProgram.cs b/JournalApp/MauiProgram.cs index 8a87f64..60ec9fe 100644 --- a/JournalApp/MauiProgram.cs +++ b/JournalApp/MauiProgram.cs @@ -1,7 +1,6 @@ using CommunityToolkit.Maui; using MudBlazor; using MudBlazor.Services; -using Plugin.Maui.AppRating; namespace JournalApp; @@ -48,8 +47,6 @@ public static MauiApp CreateMauiApp() builder.Services.AddSingleton(); builder.Services.AddSingleton(Share.Default); builder.Services.AddSingleton(); - builder.Services.AddSingleton(AppRating.Default); - builder.Services.AddSingleton(); // Seed the database. using var provider = builder.Services.BuildServiceProvider(); diff --git a/JournalApp/Resources/Raw/Credits.txt b/JournalApp/Resources/Raw/Credits.txt index 0dbde4d..9c5feb7 100644 --- a/JournalApp/Resources/Raw/Credits.txt +++ b/JournalApp/Resources/Raw/Credits.txt @@ -965,31 +965,6 @@ SOFTWARE. -https://github.com/FabriBertani/Plugin.Maui.AppRating/blob/main/LICENSE -MIT License - -Copyright (c) 2023 Fabricio Bertani - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. - - - Inspired by eMoods: https://play.google.com/store/apps/details?id=com.emoodtracker.wellness