Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant latency increases when using betterproto 2.0.0b7 compared to 2.0.0b6 #629

Open
3 tasks done
mlchen7 opened this issue Oct 17, 2024 · 1 comment
Open
3 tasks done

Comments

@mlchen7
Copy link

mlchen7 commented Oct 17, 2024

Summary

Latency increases when using the newest version 2.0.0b7

Reproduction Steps

This happened in a library we were using: https://github.com/cetanu/envoy_data_plane When we upgraded to betterproto 2.0.0b7 we saw a significant spike in the latency of our project. When we pinned the version to 2.0.0b6, the latency returned to normal. Do you have any ideas what might cause this issue?

Expected Results

No latency changes

Actual Results

Latency spiked causing increased timeouts within our project

System Information

protoc --version; python --version; pip show betterproto
/bin/sh: 1: protoc: not found
Python 3.12.4
Name: betterproto
Version: 2.0.0b6
Summary: A better Protobuf / gRPC generator & library
Home-page: https://github.com/danielgtaylor/python-betterproto
Author: Daniel G. Taylor
Author-email: [email protected]
License: MIT
Location: /usr/local/lib/python3.12/site-packages
Requires: grpclib, python-dateutil
Required-by: envoy_data_plane

Checklist

  • I have searched the issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have verified this issue occurs on the latest prelease of betterproto which can be installed using pip install -U --pre betterproto, if possible.
@mlchen7 mlchen7 added bug Something isn't working investigation needed labels Oct 17, 2024
@Gobot1234 Gobot1234 removed the bug Something isn't working label Oct 17, 2024
@Gobot1234
Copy link
Collaborator

Not without seeing a flame graph for the project no. You may get some benefit from https://pypi.org/project/betterproto-rust-codec/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@Gobot1234 @mlchen7 and others