Rename old_value to previous_value (#1863)

* Rename old_value to previous_value * Update data_point.py
SukramJ · Nov 19, 2024 · 90a99c7 · 90a99c7
1 parent 76fcff3
commit 90a99c7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/hahomematic/model/data_point.py b/hahomematic/model/data_point.py
@@ -445,8 +445,8 @@ def __init__(
                 custom_only=True,
             )
         )
-        self.__value: ParameterT = None  # type: ignore[assignment]
-        self._old_value: ParameterT = None  # type: ignore[assignment]
+        self._current_value: ParameterT = None  # type: ignore[assignment]
+        self._previous_value: ParameterT = None  # type: ignore[assignment]
         self._temporary_value: ParameterT = None  # type: ignore[assignment]
 
         self._state_uncertain: bool = True
@@ -573,9 +573,9 @@ def unconfirmed_last_value_send(self) -> ParameterT:
         )
 
     @property
-    def old_value(self) -> ParameterT:
-        """Return the old value of the data_point."""
-        return self._old_value
+    def previous_value(self) -> ParameterT:
+        """Return the previous value of the data_point."""
+        return self._previous_value
 
     @property
     def category(self) -> DataPointCategory:
@@ -592,7 +592,7 @@ def _value(self) -> ParameterT:
         """Return the value of the data_point."""
         if self._temporary_refreshed_at > self._refreshed_at:
             return self._temporary_value
-        return self.__value
+        return self._current_value
 
     @state_property
     def value(self) -> ParameterT:
@@ -724,7 +724,7 @@ def write_value(self, value: Any) -> tuple[ParameterT, ParameterT]:
 
         self._reset_temporary_value()
 
-        old_value = self.__value
+        old_value = self._current_value
         if value == NO_CACHE_ENTRY:
             if self.refreshed_at != INIT_DATETIME:
                 self._state_uncertain = True
@@ -736,8 +736,8 @@ def write_value(self, value: Any) -> tuple[ParameterT, ParameterT]:
             self._set_refreshed_at()
         else:
             self._set_modified_at()
-            self._old_value = old_value
-            self.__value = new_value
+            self._previous_value = old_value
+            self._current_value = new_value
             self._state_uncertain = False
         self.fire_data_point_updated_callback()
         return (old_value, new_value)

diff --git a/hahomematic/model/hub/data_point.py b/hahomematic/model/hub/data_point.py
@@ -84,7 +84,7 @@ def __init__(
         self._min: Final = data.min_value
         self._unit: Final = data.unit
         self._value = data.value
-        self._old_value: bool | float | int | str | None = None
+        self._previous_value: bool | float | int | str | None = None
         self._service_methods = get_service_calls(obj=self)
 
     @state_property
@@ -93,9 +93,9 @@ def available(self) -> bool:
         return self.central.available
 
     @property
-    def old_value(self) -> Any | None:
-        """Return the old value."""
-        return self._old_value
+    def previous_value(self) -> Any | None:
+        """Return the previous value."""
+        return self._previous_value
 
     @state_property
     def value(self) -> Any | None:
@@ -155,7 +155,7 @@ def write_value(self, value: Any) -> None:
             self._set_refreshed_at()
         else:
             self._set_modified_at()
-            self._old_value = old_value
+            self._previous_value = old_value
             self._value = value
 
         self.fire_data_point_updated_callback()