Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect highlighting for push constants #107

Open
JesperLykke opened this issue Sep 30, 2022 · 6 comments
Open

Incorrect highlighting for push constants #107

JesperLykke opened this issue Sep 30, 2022 · 6 comments

Comments

@JesperLykke
Copy link

Installed product versions

  • Visual Studio: [2019 Enterprise]
  • This extension: [0.11.160] (Downloaded from VS own marketplace.

Description

I simply get a red squiggly line below my push constant - which compiles and works perfectly well.

image

@helviett
Copy link

helviett commented Oct 6, 2022

Do you compile shader via external compiler? Do you pass -V argument to the external compiler?

@JesperLykke
Copy link
Author

Hm.... I compile the shaders to Spir-V simply using the "glslc.exe" from the Vulkan SDK. I do not pass any special arguments. In either case, what should that have do with the syntax highlighting?

@danielscherzer
Copy link
Owner

The syntax highlighting ask the compiler set in the options for an error list and produces the squiggles.

@redgogh
Copy link

redgogh commented Aug 10, 2024

I have this problem too, why do i need to pass -V argument to the external compiler? recommend remove this syntax highlighting check. because all developers understand what they are doing in any case.

@danielscherzer
Copy link
Owner

danielscherzer commented Aug 10, 2024

What do you mean by "remove this syntax highlighting check"?

To hopefully clarify: To create the red squiggles I need to know where the (compile) errors in the code are. If you set the external compiler in the options I use this compiler to generate the red squiggles. Depending on the external compiler you may need to use options, but this is specific to the external compiler you are using. If you do not set an external compiler I use the default compiler of your OpenGL driver. This driver does not understand Vulkan specific extensions to GLSL.

@redgogh
Copy link

redgogh commented Aug 10, 2024

All right, i thought was it is a GLSL extension internal syntax highlighting check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants