Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload GraphQL Schema #12

Open
BenSlabbert opened this issue May 23, 2020 · 2 comments · May be fixed by #17
Open

FileUpload GraphQL Schema #12

BenSlabbert opened this issue May 23, 2020 · 2 comments · May be fixed by #17
Labels
enhancement New feature or request

Comments

@BenSlabbert
Copy link

Hello! Thanks for a great repo!

From what I can see there is no support for the scalar type Upload?

Please see this example from 99designs.

Please let me know if I have made an error or if this is an opportunity for a PR :)
@danielvladco
Copy link
Owner

Hi @BenSlabbert , this is a great Idea. At the moment of writing this lib there wasn't such a functionality. Of corse you can open a PR.

Actually I thought about this at some point and I think Upload type would map perfectly as protobuf bytes

toctan added a commit to toctan/go-proto-gql that referenced this issue Nov 3, 2020
@toctan
Unmarshal graphql.Upload into []byte
719dcb8 
Close danielvladco#12
@toctan toctan linked a pull request Nov 3, 2020 that will close this issue
Open
@danielvladco danielvladco added the enhancement New feature or request label Apr 12, 2021
@danielvladco
Copy link
Owner

Hi @BenSlabbert , @toctan thank you for your contribution, I am planning to add this feature, however since @toctan 's last PR I did a big refactor to clean up the codebase so if you are willing resolve the conflicts that will be great.

Also I am wondering if just adding case graphql.Upload: to Bytes type will be enough to allow this functionality...
I have a feeling that we need to introduce a new scalar of type Upload but I am not very familiar with how gqlgen handles Upload files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unmarshal graphql.Upload into []byte toctan/go-proto-gql
2 participants
@BenSlabbert @danielvladco