-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work, does not report errors #9
Comments
Add puml-for-markdown -s http://localhost:8089 -i ./.md.gitignore -d --image-formats both --turn-off-link-shortening or like: https://github.com/danielyaa5/puml-for-markdown/blob/main/.husky/pre-commit |
I see, so generating images is a mandatory step then and Sorry I assumed from the docs's Advanced Usage: that it is optional. Adding the There are now some images in Using the additional parameters you mentioned (without the custom server as I explained), the program ends on what seems like an unhandled HTTP request. Can you tell me which combination of parameters should I use to get the simple diagram in the provided MWE, if I don't have a custom PlantUML server? |
Anyone is welcome to try an alternative until this is resolved: https://github.com/grissius/plantaznik. I've written it without notion of this project and wanted to compare the two, but I did not manage to do a simple hello-world example. |
I understand it doesn't work with inline blocks:
U should define link to P.S. Try to create a demo repository or debug it, there is a simple js file, in general, you can figure it out in 15 minutes. About PlantUML server.// docker-compose.yml
version: '3'
services:
plantuml-server:
build:
context: .
dockerfile: Dockerfile
ports:
- 8089:8080
// Dockerfile
FROM plantuml/plantuml-server:tomcat
EXPOSE 8080 First, you need to install Docker Compose. docker-compose up -d && docker-compose logs -f If Go to VSCode jebbs.plantuml pluginSetup in .vscode/workspace.code-workspace {
"settings": {
// plantuml-server
"plantuml.render": "PlantUMLServer",
"plantuml.server": "http://localhost:8089"
}
} CurlUse curl -s -X POST --data-binary @mydb.plantuml -H "Content-Type:text/plain" localhost:8089/png > mydb.png Path AppSecDisallow include |
But I don't use the inline blocks in the provided MWE, do I?
Exactly what I did in the MWE, links were not replaced, however. So based on your answer I assume I do need local PlantUML server? I can run it ofc, but I don't want to for every update of the readme, that was my point. The public one should be usable.
I guess this answers my question on the ease of use, if I should debug the primary basic functionality. Thanks for the help @NikitaIT , I am sorry we are not able to make the tool work with the public PlantUML server, with literally a single markdown and PlantUML file. |
Following the README, the program does not seem to work for me. Maybe there is something I missed in the setup?
Here are steps to reproduce:
Expected: Updates the readme or prints error message.
The text was updated successfully, but these errors were encountered: