You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Invalid start state in report
In the recent changes, we use the context from the replay buffer when self.config.replay_context > 0. But for report method, currently, the code always passes the start state zeros context as carry. Maybe we mirror what's done in train and use the replay context if it is set?
I don't see the point of carry for train and report methods. I understand that we might need it for online training, where we are observing one observation (or batch of single timestep observations) at each train step and returning the encoded posterior after train step. But I think this is purely conceptual and does not serve any purpose right now?
The text was updated successfully, but these errors were encountered:
Invalid start state in report
In the recent changes, we use the context from the replay buffer when
self.config.replay_context > 0
. But for report method, currently, the code always passes the start state zeros context ascarry
. Maybe we mirror what's done in train and use the replay context if it is set?I don't see the point of
carry
for train and report methods. I understand that we might need it for online training, where we are observing one observation (or batch of single timestep observations) at each train step and returning the encoded posterior after train step. But I think this is purely conceptual and does not serve any purpose right now?The text was updated successfully, but these errors were encountered: