Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid start states used for report method and can "carry" be eliminated in train/report methods #157

Open
sai-prasanna opened this issue Oct 9, 2024 · 0 comments

Comments

@sai-prasanna
Copy link

  1. Invalid start state in report
    In the recent changes, we use the context from the replay buffer when self.config.replay_context > 0. But for report method, currently, the code always passes the start state zeros context as carry. Maybe we mirror what's done in train and use the replay context if it is set?

  2. I don't see the point of carry for train and report methods. I understand that we might need it for online training, where we are observing one observation (or batch of single timestep observations) at each train step and returning the encoded posterior after train step. But I think this is purely conceptual and does not serve any purpose right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant