-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide response form #204
Comments
The solution is to change the code of the ReactJS plugin so that when the comment form has been submitted without issues the form disappears. |
I can take a stab at this, @danirus |
One detail that comes to my mind about this is that when submitting the form there might be errors. We have to be sure that the form gets hidden only after the submission has happened and there's nothing else to tell to the user. When the person posting the comment is not an authenticated user the form displays an info alert div to tell the user that a confirmation email has been sent. We still need to inform the user in that case. |
@mckinly please tell me, are you working on this improvement?) |
No, not any longer.
…On Sat, Dec 19, 2020, 07:24 ogurec-ogurec ***@***.***> wrote:
@mckinly <https://github.com/mckinly> please tell me, are you working on
this improvement?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXWDOXAI3OGH2STBMITM7TSVSSR5ANCNFSM4QDTJ66A>
.
|
Sorry for the late reply, @ogurec-ogurec. The code is in |
Hello, Danirus. @danirus I am trying now to make the form hide after the response is submitted. Please tell me how I can do this. Tried changing is_visible = false but doesn't work :( |
I would apply the following changes:
But remember that the code doesn't check whether there were issues in the form. If you hide it and there were form errors, the user doesn't have a way to know it. You would have to keep the form open to allow the user to see the message with the errors. Maybe you could call the |
@danirus big thanks. |
hello, the first option turned out (comment.jsx), thanks. Trying to implement the second option (commentform.jsx) the
But somehow it doesn't work out. @danirus |
Please tell me how I can hide the response form after the user has clicked "Submit" in the form. A similar logic occurs when you click on the "Reply" button. I would like to make the form disappear after the user clicks the "Send" button.
I would be grateful for any help
The text was updated successfully, but these errors were encountered: