Rel 3.0.0 #224
Closed
Rel 3.0.0 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Watch whether comment model is other than XtdComment. * Take into account the SITE_ID. * Watch the value of django-comments' COMMENTS_HIDE_REMOVED setting.
Issue 194
…templates: * django_comments_xtd/templates/comments/form_js.html * django_comments_xtd/templates/comments/preview.html * django_comments_xtd/templates/comments/reply_button.html * django_comments_xtd/templates/comments/reply_form_js.html
just a grammar correction, "envoyé" must be "accordé" (may be in-tune in english) with "commentaire" and "commentaire" is a male gender noum so only one e at the end of the word.
…reactions: Use post_delete django signal to trigger deletion of: * all nested comments, * updated nested_count attributes in parents nodes, * delete related CommentReaction and CommentReactionAuthor objects.
The new template tag allows developers to provide their own django template to render the reactions_panel used by the reactions.js module. The template path is "comments/reactions_panel_template.html".
This was
linked to
issues
Feb 17, 2022
New test directory "js_tests/tests/scene3".
Provide 1st. additional theme 'avatar_in_thread' and allow switching the theme with customizable setting COMMENTS_XTD_THEME_DIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 3.0.0:
COMMENTS_HIDE_REMOVEDand the new settingCOMMENTS_XTD_PUBLISH_OR_WITHHOLD_NESTED. Up until v3.0.0 removed comments were listed but their content were not displayed. They showed a "comment has been removed" message instead. That behaviour didn't fully comply with parent's app, django-comments settingCOMMENTS_HIDE_REMOVED. By defaultCOMMENTS_HIDE_REMOVEDisTrue, which has the effect of hiding removed comments. As of v3.0.0 this is also the behaviour of django-comments-xtd. Additionally a new settingCOMMENTS_XTD_PUBLISH_OR_WITHHOLD_NESTEDhas been created to control whether nested comments of a comment being removed or approved will be withhold or published.