Skip to content

Commit 06ac746

Browse files
committed
bumped to Visual Studio warning level 4
1 parent 5a4209b commit 06ac746

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
3737
add_compile_options_safe(-Wuseless-cast)
3838
elseif (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
3939
add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
40-
# TODO: bump warning level
41-
#add_compile_options(/W4) # Warning Level
42-
# TODO: enable warning
40+
add_compile_options(/W4) # Warning Level
41+
add_compile_options(/wd4244) # warning C4244: 'x': conversion from 'int' to 'char', possible loss of data
4342
add_compile_options(/wd4267) # warning C4267: '...': conversion from 'size_t' to 'unsigned int', possible loss of data
4443
elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
4544
add_compile_options(-Weverything)

0 commit comments

Comments
 (0)