Fix #765 - prevent fatal error when users don't have access to any gr…

…oups.
danmarsden · Sep 16, 2024 · de17325 · de17325
1 parent 01bfb89
commit de17325
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/classes/form/export.php b/classes/form/export.php
@@ -43,6 +43,7 @@ public function definition() {
         $course        = $this->_customdata['course'];
         $cm            = $this->_customdata['cm'];
         $modcontext    = $this->_customdata['modcontext'];
+        $grouplist    = [];
 
         $mform->addElement('header', 'general', get_string('export', 'attendance'));
 
@@ -76,11 +77,14 @@ public function definition() {
             return;
         }
 
-        list($gsql, $gparams) = $DB->get_in_or_equal(array_keys($grouplist), SQL_PARAMS_NAMED);
-        list($usql, $uparams) = $DB->get_in_or_equal(array_keys($userlist), SQL_PARAMS_NAMED);
-        $params = array_merge($gparams, $uparams);
-        $groupmembers = $DB->get_recordset_select('groups_members', "groupid {$gsql} AND userid {$usql}", $params,
-                                                  '', 'groupid, userid');
+        $groupmembers = [];
+        if (!empty($grouplist)) {
+            list($gsql, $gparams) = $DB->get_in_or_equal(array_keys($grouplist), SQL_PARAMS_NAMED);
+            list($usql, $uparams) = $DB->get_in_or_equal(array_keys($userlist), SQL_PARAMS_NAMED);
+            $params = array_merge($gparams, $uparams);
+            $groupmembers = $DB->get_recordset_select('groups_members', "groupid {$gsql} AND userid {$usql}", $params,
+                                                      '', 'groupid, userid');
+        }
         $groupmappings = [];
         foreach ($groupmembers as $groupmember) {
             if (!isset($groupmappings[$groupmember->groupid])) {