Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disingenuous naming #4

Open
pmanole-volvocars opened this issue Jul 5, 2024 · 3 comments
Open

Disingenuous naming #4

pmanole-volvocars opened this issue Jul 5, 2024 · 3 comments

Comments

@pmanole-volvocars
Copy link

I think it's a bit disingenuous to name your package ts-to-effect-schema, say you're targeting @effect/schema in your about header, then say you're targeting Zod in your README.md. Which is it? Did you do this just to snag a package name?

But it's your package, you name it what you want. I just think this puts a dark stain on your open source packages and your name.

@adrian-gierakowski
Copy link

The source was originally copied from a similar project which targeted zod. The author just didn’t bother to update the readme

@brokenthorn
Copy link

The source was originally copied from a similar project which targeted zod. The author just didn’t bother to update the readme

OK. I guess. I still think though that a rename shouldn't have been that hard to do and it would help people find the package more easily as well by searching for what they want and getting what they expect as a result.
I certainly didn't expect to get a Zod library when I searched for Effect.

@mz-makerstudio
Copy link

Yes looks like readme is similar to this repo - https://github.com/fabien0102/ts-to-zod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants