From 73e6889a1335b386d0b642d1439a29084d01df4d Mon Sep 17 00:00:00 2001 From: Martin Lundfall Date: Wed, 25 Mar 2020 13:04:53 +0100 Subject: [PATCH] mark failing tests with fail (now that chief is patched) --- src/chief-exploits.t.sol | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/chief-exploits.t.sol b/src/chief-exploits.t.sol index ba45c65..9b640e5 100644 --- a/src/chief-exploits.t.sol +++ b/src/chief-exploits.t.sol @@ -85,7 +85,7 @@ contract DSChiefTest is DSThing, DSTest { // variants of the slate camping exploit - function test_exploit_A() public { + function testFail_exploit_A() public { approveAll(); innocentVoterA.lock(50 ether); innocentVoterB.lock(50 ether); @@ -133,7 +133,7 @@ contract DSChiefTest is DSThing, DSTest { } // "single candidate slate camping" - function test_exploit_B() public { + function testFail_exploit_B() public { approveAll(); innocentVoterA.lock(50 ether); innocentVoterB.lock(50 ether); @@ -168,7 +168,7 @@ contract DSChiefTest is DSThing, DSTest { // as a last ditch effort, an attacker can _always_ remove approvals and perma-lock mkr if they are willing to spend mkr first. // this may be necessary if every slate combination of candidates with some approval amount has already been etched // and the attacker doesn't want to play the waiting game required for variant b - function test_exploit_C() public { + function testFail_exploit_C() public { approveAll(); innocentVoterA.lock(50 ether); innocentVoterB.lock(50 ether); @@ -232,8 +232,8 @@ contract DSChiefTest is DSThing, DSTest { // if two people have been exploited and can no longer free their mkr, // it only takes one person depositing mkr to make both other voters' mkr available again // in the best case, b/c the slate size if 5, one person can allow 4 people to free their mkr - function test_one_mkr_in_two_mkr_out() public { - test_exploit_A(); + function testFail_one_mkr_in_two_mkr_out() public { + testFail_exploit_A(); // both innocent voters have deposits assertEq(chief.deposits(address(innocentVoterA)), 50 ether); assertEq(chief.deposits(address(innocentVoterB)), 50 ether);