Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

Strip metadata before calculating proof hash #406

Open
asymmetric opened this issue Apr 17, 2020 · 7 comments
Open

Strip metadata before calculating proof hash #406

asymmetric opened this issue Apr 17, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@asymmetric
Copy link
Contributor

So that changes that don't affect the bytecode don't cause a cache miss.

@asymmetric asymmetric added the enhancement New feature or request label Apr 17, 2020
@asymmetric asymmetric changed the title Strip metadata before calcluating proof hash Strip metadata before calculating proof hash Apr 17, 2020
@livnev
Copy link
Member

livnev commented Apr 17, 2020

dapphub/dapptools@78508c6
Using the methodology introduced in this commit (or potentially the methodology from before) could be one way.

@d-xo
Copy link
Contributor

d-xo commented Apr 18, 2020

Could we expose this as a command in hevm / seth? (smth like hevm --strip-metadata) and then just reuse it in klab?

@MrChico
Copy link
Member

MrChico commented Apr 18, 2020

dapphub/dapptools#357
a little more verbose than one would like perhaps (hevm strip-metadata --code XXXXXX), but an easy way to get the job done while keeping in line with the constraints of optparse generic

@asymmetric
Copy link
Contributor Author

Closed by dapphub/dapptools#357.

@d-xo
Copy link
Contributor

d-xo commented Apr 23, 2020

@asymmetric I don't think the linked PR closes this issue? We still need to incorporate this functionality in klab afaik?

@asymmetric
Copy link
Contributor Author

Ah, I thought we would do it manually, sorry. Feel free to reopen if that’s not the case.

@asymmetric asymmetric reopened this Apr 23, 2020
@asymmetric
Copy link
Contributor Author

It makes more sense to include it as part of the build process, I agree 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants