Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure App Configuration component: use Go durations instead of nanoseconds for metadata options #2976

Closed
ItalyPaleAle opened this issue Jul 10, 2023 · 1 comment · Fixed by #3004
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@ItalyPaleAle
Copy link
Contributor

The Azure App Configuration component has 4 metadata options that are durations, and those are defined as integers indicating nanoseconds (1 second =1_000_000_000 nanoseconds). This is a sub-par experience for end users.

The component should be updated to use time.Duration for those fields. The metadata parser automatically parses that as Go durations (e.g. "5s", or "2m"), which is a much better experience for users, and more aligned with the rest of Dapr.

This is a backwards-incompatible change that can be done to this alpha component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants