Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registering actor from Type but not only GenericType #202

Closed
nero-philip-wang opened this issue Jan 16, 2020 · 5 comments · May be fixed by #1091
Closed

Add registering actor from Type but not only GenericType #202

nero-philip-wang opened this issue Jan 16, 2020 · 5 comments · May be fixed by #1091
Assignees
@LMWF @nero-philip-wang
Labels
area/actor/runtime

Comments

@nero-philip-wang
Copy link

Add registering actor from Type but not only GenericType so that we can registe actor automatically.

public void RegisterActor(Type tActor, Func<ActorTypeInformation, ActorService> actorServiceFactory = null)
@amanbha
Copy link
Contributor

amanbha commented Jan 16, 2020

@nero-philip-wang Could you explain the scenario in a bit more detail. How would you enforce here that TActor is of type Actor? It would be a runtime exception.

@nero-philip-wang
Copy link
Author

I think if registering actor from GenericType, types should be konwn when writing code. But if some types are found by reflection in runtime, I cannot register them.

@amanbha
Copy link
Contributor

amanbha commented Mar 12, 2020

@nero-philip-wang Would you like to contribute and create a PR for this.

@nero-philip-wang nero-philip-wang mentioned this issue Mar 18, 2020
Closed
3 tasks
@amanbha
Copy link
Contributor

amanbha commented Jul 21, 2020

Closing as the PR was closed due to no activity from contribtutor.

@amanbha amanbha closed this as completed Jul 21, 2020
@nero-philip-wang nero-philip-wang mentioned this issue May 18, 2023
Draft
3 tasks
@nero-philip-wang
Copy link
Author

Closing as the PR was closed due to no activity from contribtutor.
Very SORRY for leaving. I'm back now and add new PR for it. Should I make this issue reopen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LMWF LMWF

@nero-philip-wang nero-philip-wang

Labels
area/actor/runtime
Projects
None yet
Milestone
No milestone
3 participants
@amanbha @LMWF @nero-philip-wang