Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate calls to Dapr's sidecar Actor APIS to GRPC #486

Open
artursouza opened this issue Nov 22, 2020 · 4 comments · May be fixed by #954
Open

Migrate calls to Dapr's sidecar Actor APIS to GRPC #486

artursouza opened this issue Nov 22, 2020 · 4 comments · May be fixed by #954
Assignees
@addjuarez
Labels
area/actor/client area/actor/runtime area/actor kind/enhancement New feature or request technical debt
Milestone
Future

Comments

@artursouza
Copy link
Member

Applications can use GRPC (in addition to HTTP) to make API calls for Actor.
This impacts Actor client and Actor runtime.
A property or environment variable can be used to switch between HTTP or GRPC communication.
GRPC communication is the default.

RELEASE NOTE: Support GRPC communication for Actor APIs into Dapr.
@vinayada1 vinayada1 added this to the Post v1.0 milestone Jan 6, 2021
@artursouza
Copy link
Member Author

Actor Client making HTTP calls: https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.Actors/Communication/Client/ActorNonRemotingClient.cs

Actor Proxy, using the HTTP client:

dotnet-sdk/src/Dapr.Actors/Client/ActorProxy.cs

Line 110 in fe1e697

public async Task<TResponse> InvokeMethodAsync<TRequest, TResponse>(string method, TRequest data, CancellationToken cancellationToken = default)

@berndverst
Copy link
Member

@halspang please assign to @addjuarez. Priority P1, for upcoming v1.9 release. FYI @artursouza

This is related to dapr/dapr#5118

@addjuarez
Copy link

/assign

@addjuarez addjuarez linked a pull request Sep 21, 2022 that will close this issue
Open
3 tasks
@artursouza artursouza mentioned this issue Oct 20, 2022
Open
@adamreed90
Copy link

Curious of the status of this? :D

@shubham1172 shubham1172 mentioned this issue May 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addjuarez addjuarez

Labels
area/actor/client area/actor/runtime area/actor kind/enhancement New feature or request technical debt
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Migrate actors to use grpc addjuarez/dotnet-sdk
6 participants
@artursouza @rynowak @berndverst @addjuarez @adamreed90 @vinayada1