-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing JsonPropertyName to Data property #1000
Conversation
ba39d72
to
ca3787b
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 171 171
Lines 5758 5758
Branches 626 626
=======================================
Hits 3825 3825
Misses 1784 1784
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@approvers-dotnet-sdk: anything else needed ? |
ca3787b
to
cc1e276
Compare
008e7df
to
92ad699
Compare
…o force the JsonSerializer to use camelCase with JsonSerializerOptions Signed-off-by: Nenad Steric <[email protected]> Signed-off-by: Nenad Steric <[email protected]>
@NenadSteric Thank you for your contribution! Upon digging into this, the various Dapr clients utilize a Further, because a As such, I'm going to go ahead and reject this PR because as the underlying intent is to use a camel-cased name and it's already doing that by default and in an easily overridable manner, we're already at the desired outcome without any changes at all. That said, if you think I'm missing something, please feel free to re-open with any follow-ups and I'd be happy to re-engage! |
without it you need to force the JsonSerializer to use camelCase with JsonSerializerOptions
Description
adds JsonPropertyName to make the casing consistent with the other properties.
This also makes it possible to use just Serialize without JsonSerializerOptions
as the pubsub json handling code in Dapr needs this property to be lowercase.
This problem had to be fixed during testing of the new Bulk-publish API
where I needed to serialize the CloudEvent classes manually without the DaprClient.
Issue reference
as discussed in
#976 and #944
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Please comment if any new tests or documentation needs to be created.