Ensure ActorRuntime can be instantiated using Properties #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <[email protected]>
|
@artursouza @cicoyle @salaboy could you please take a look and let me know your thoughts. Thank you! |
|
@artursouza and @cicoyle sorry to insist, could you please review and approve. Thank you! |
|
@artur-ciocanu can we close this in favour of this one: #1192 ? |
|
All the changes from this PR have been incorporated into #1192. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tiny PR extends the
ActorRuntimeby adding and overloadgetInstance(Properties properties)that allows us to provide the Dapr ports during instantiation, this is especially useful in integration tests and when integrating with Testcontainers.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1202
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: