Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking Handle #186

Open
XavierGeerinck opened this issue Feb 14, 2022 · 3 comments
Open

Leaking Handle #186

XavierGeerinck opened this issue Feb 14, 2022 · 3 comments
Labels
bug Something isn't working pinned

Comments

@XavierGeerinck
Copy link
Contributor

Expected Behavior

lsof -i tcp -n -P should not show any daprd or node processes running once our app stops

Actual Behavior

Processes are not correctly closing. This seems to happen in Actors when server.actors.init() was called and at least 1 actor was registered through server.actors.registerActor(<Class>)

Afterwards when stopping the server, it hangs

A fix was applied through PR #184 that will force our HTTP Server to close after 1 second, resolving tests. The root cause however stays present

@XavierGeerinck XavierGeerinck added the enhancement New feature or request label Feb 15, 2022
@tanvigour
Copy link

Is this more of a bug than enhancement?

@shubham1172
Copy link
Member

The original bug has been fixed with a hack, but we need to fix the root cause rather than terminating forcefully.

@XavierGeerinck XavierGeerinck added bug Something isn't working and removed enhancement New feature or request labels Mar 21, 2022
@shubham1172 shubham1172 added this to the Dapr Node.js SDK - v2.3.0 milestone May 12, 2022
@XavierGeerinck XavierGeerinck modified the milestones: Dapr Node.js SDK - v2.5.0, Dapr Node.js SDK - v2.6.0, Dapr Node.js SDK - v3.0.0 Sep 27, 2022
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned
Projects
None yet
Development

No branches or pull requests

4 participants