Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Support for Per Actor Type Configuration #243

Open
halspang opened this issue Apr 7, 2022 · 6 comments
Open

Feature: Add Support for Per Actor Type Configuration #243

halspang opened this issue Apr 7, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request enhancement-runtime-dependency New feature or request due to a runtime feature pinned

Comments

@halspang
Copy link

halspang commented Apr 7, 2022

Describe the proposal

The Dapr Runtime added support for per actor type configurations in 1.7. This support needs to be added to the SDKs.

The new configuration looks like:

{
  "entities":["actorType1", "actorType2"],
  "actorIdleTimeout": "1h",
  "actorScanInterval": "30s",
  "drainOngoingCallTimeout": "30s",
  "drainRebalancedActors": true,
  "reentrancy": {
    "enabled": true,
    "maxStackDepth": 32
  },
  "entitiesConfig": [
      {
          "entities": ["actorType1"],
          "actorIdleTimeout": "1m",
          "drainOngoingCallTimeout": "10s",
          "reentrancy": {
              "enabled": false
          }
      }
  ]
}

Implementation can be varied per SDK but should output to the above JSON.

Docs: dapr/docs#2334
Runtime: dapr/dapr#4201

Edit @ 24/OCT/2022 - Xavier Geerinck:

Proposing to update the spec to this:

await server.actor.registerActor(DemoActorReminderTtlImpl, {
    "actorIdleTimeout": "1m",
    "drainOngoingCallTimeout": "10s",
    "reentrancy": {
        "enabled": false
     }
});

The above will allow easy configuration on the registration of the actor type. It will however be more difficult to utilize the "entities" field in the spec as described above as we will take it per actor type uniquely rather than allowing bulk types to be changed individually as allowed by the "entities" spec.

@amulyavarote amulyavarote added enhancement New feature or request P1 labels Apr 12, 2022
@shubham1172 shubham1172 added this to the Dapr Node.js SDK - v2.3.0 milestone May 12, 2022
@XavierGeerinck XavierGeerinck changed the title Add Support for Per Actor Type Configuration Feature: Add Support for Per Actor Type Configuration May 17, 2022
@msfussell msfussell added the enhancement-runtime-dependency New feature or request due to a runtime feature label Jun 8, 2022
@XavierGeerinck
Copy link
Contributor

@tanvigour could you update the status of this one? :)

@XavierGeerinck XavierGeerinck modified the milestones: Dapr Node.js SDK - v2.5.0, Dapr Node.js SDK - v2.6.0 Sep 27, 2022
@shubham1172 shubham1172 modified the milestones: Dapr Node.js SDK - v2.6.0, Dapr Node.js SDK - v2.5.0 Sep 27, 2022
@XavierGeerinck
Copy link
Contributor

Proposal needs more work at SDK level so will move this to 3.0 as we need to agree on the API spec. Added proposal to the original issue

@dapr-bot
Copy link
Collaborator

dapr-bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Jan 8, 2023
@XavierGeerinck
Copy link
Contributor

/keep-alive

@dapr-bot
Copy link
Collaborator

dapr-bot commented Mar 9, 2023

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Mar 9, 2023
@shubham1172
Copy link
Member

/keep-alive

@dapr-bot dapr-bot removed the stale label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request enhancement-runtime-dependency New feature or request due to a runtime feature pinned
Projects
None yet
Development

No branches or pull requests

8 participants