Fix protobuf.sh #33
Merged
Fix protobuf.sh #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngbupark
approved these changes
May 29, 2020
vinayada1
reviewed
May 29, 2020
| FILE_PATH="${PROTO_PATH}/${FILE_NAME}/v1" | ||
| FOLDER_NAME=$1 | ||
| FILE_NAME=$2 | ||
| FILE_PATH="${PROTO_PATH}/${FOLDER_NAME}/v1" |
There was a problem hiding this comment.
Doesn't this need to be: FILE_PATH="${PROTO_PATH}/${FOLDER_NAME}/v1/{FILE_NAME}" ?
There was a problem hiding this comment.
We are using FILE_PATH to create directories as needed in that path. Having filename there would create another folder with name {FILE_NAME} which we do not want to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated protobuf.sh to work with changes to proto files in dapr/dapr
Issue reference
Please reference the issue this PR will close: #32
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: