add missing body-parser package to js pub_sub order-processor #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch @contributor thank you. LGTM manually. I'm running test automation now to validate. |
|
There is a new test failure on crypto api. Needs investigation, even though not related to this. |
|
thank you for the contribution |
|
@holopin-bot @contributor Thank you! |
|
Congratulations @contributor, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbj3w512210ckvqc6z7eim This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pub_sub quick start projects crashes with:
== APP - order-processor-http == Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'body-parser'The PR adds body-parser version ^1.19.0 - the newest one used in other quick start projects
Issue reference
No related issue created