-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Deploy to Heroku' Button #24
Comments
I use Dokku (https://github.com/dokku/dokku) for a lot of my deployments. I'm not opposed to a 'Deploy to Heroku' button, but I've never used the service. If you want to submit a patch for it, I will gladly accept it. |
I will try to send a PR next month. If I come across bigger problems I will let you know here so that you can add it to your todo pile. 😅 |
Do you have a logo I should use. This is an example app.json from Heroku: Logo and keywords are optional but I think it cannot hurt to use them? 🤔 |
Nope. I don't have a logo. I never considered the project to be "that big" that it needed one. It was mainly developed so I could use it in-house with a few clients that I supported. When I stopped supporting them about 18 months ago, I stopped updating the project. ...but if there's interest, the next time I get a free moment I will put some work into the project. |
I suppose I could get someone to design a logo for $10 on fiverr... |
I will leave out the logo for now and we just update the app.json when you have one. It is not necessary. |
Awesome. I merged the PR into the development branch along with a few library updates to use the latest version of Django. Let me know if it fails to fix the problem you were having. |
Awesome! Heroku now tells me:
😀 |
...but does it work? |
No, it does not work. You can follow the link for details.
|
What do you think of creating a 'Deploy to Heroku' button? That would make the setup on Heroku much more simple. 😎
The text was updated successfully, but these errors were encountered: