Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Deploy to Heroku' Button #24

Open
FlorenceWilliamson opened this issue May 22, 2018 · 10 comments
Open

'Deploy to Heroku' Button #24

FlorenceWilliamson opened this issue May 22, 2018 · 10 comments

Comments

@FlorenceWilliamson
Copy link

What do you think of creating a 'Deploy to Heroku' button? That would make the setup on Heroku much more simple. 😎

@darkpixel
Copy link
Owner

I use Dokku (https://github.com/dokku/dokku) for a lot of my deployments. I'm not opposed to a 'Deploy to Heroku' button, but I've never used the service.

If you want to submit a patch for it, I will gladly accept it.
If not, I'll add it to my 'todo pile' and get to it sometime in the next few decades... ;)

@FlorenceWilliamson
Copy link
Author

I will try to send a PR next month. If I come across bigger problems I will let you know here so that you can add it to your todo pile. 😅

@FlorenceWilliamson
Copy link
Author

Do you have a logo I should use.
My suggested keywords are "python", "django", "status", "statuspage", "open source", "productivity". Do you have other points?

This is an example app.json from Heroku:
{
"name": "Node.js Sample",
"description": "A barebones Node.js app using Express 4",
"repository": "https://github.com/heroku/node-js-sample",
"logo": "https://node-js-sample.herokuapp.com/node.png",
"keywords": ["node", "express", "static"]
}

Logo and keywords are optional but I think it cannot hurt to use them? 🤔

@darkpixel
Copy link
Owner

Nope. I don't have a logo. I never considered the project to be "that big" that it needed one. It was mainly developed so I could use it in-house with a few clients that I supported. When I stopped supporting them about 18 months ago, I stopped updating the project.

...but if there's interest, the next time I get a free moment I will put some work into the project.

@darkpixel
Copy link
Owner

I suppose I could get someone to design a logo for $10 on fiverr...

@FlorenceWilliamson
Copy link
Author

I will leave out the logo for now and we just update the app.json when you have one. It is not necessary.

@darkpixel
Copy link
Owner

Awesome. I merged the PR into the development branch along with a few library updates to use the latest version of Django. Let me know if it fails to fix the problem you were having.

@FlorenceWilliamson
Copy link
Author

Awesome! Heroku now tells me:

Your app was successfully deployed.

😀

@darkpixel
Copy link
Owner

...but does it work?

@FlorenceWilliamson
Copy link
Author

No, it does not work. You can follow the link for details.

No module named stronghold.decorators
https://a45r436z56z7547467.herokuapp.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants