-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexpected api endpoint availability #585
Comments
Hey @teodorescuserban I plan to bring this feature in the PR #589. |
@teodorescuserban you can already try it using: xcaddy build --with github.com/darkweak/souin@e5c1440eb3a0c1c6832488a6605e842c09ecc04a --with github.com/darkweak/souin/plugins/caddy@e5c1440eb3a0c1c6832488a6605e842c09ecc04a and send the following request (assuming you're running it on localhost and enabled souin api in the config):
|
@darkweak maybe wrong sha?
|
@teodorescuserban this one |
I tested it and it works! However, setting My cache config looks like this:
It will only work with this config:
It does look promising though, @darkweak ! |
I am using souin as caddy module.
I only cache some of the requests. I was very surprised to notice (after a couple of hours of unsuccessful tries) that in certain configurations the souin api endpoint is not available. More precise, if a request to
/souin-api/souin
is not configured to be cached, the api won't respond.Like in this
Caddyfile
example:Now, I don't have a sane suggestion. My first instinct would tell me that it would be nice to have the souin-api endpoint liked to the caddy admin port instead. But there are a number of problems with that.
Perhaps the best solution would br to just document that (with a nice example of how to also secure the souin api endpoint from external).
Keep up the good work, @darkweak !
The text was updated successfully, but these errors were encountered: