Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update uninstall script to remove darlingserver and darling-coredump #1505

Closed
wants to merge 5 commits into from
Closed

Update uninstall script to remove darlingserver and darling-coredump #1505

wants to merge 5 commits into from

Conversation

luchsj
Copy link
Contributor

@luchsj luchsj commented Apr 5, 2024

Adds two lines after darling's executables are removed which remove darlingserver and darling-coredump's executables.
Resolves #1503.

@CuriousTommy
Copy link
Contributor

I think it would be better if you create a new branch and cherry-pick the 53ea347 commit. I want to avoid adding unnecessary commits.

@CuriousTommy
Copy link
Contributor

Hey @luchsj, I cherry-picked your commit and pushed it to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tools/uninstall does not remove all executables
2 participants
@luchsj @CuriousTommy