Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not glue too tightly to coincurve #27

Closed
ztane opened this issue Jan 31, 2022 · 8 comments · Fixed by #28
Closed

Do not glue too tightly to coincurve #27

ztane opened this issue Jan 31, 2022 · 8 comments · Fixed by #28

Comments

@ztane
Copy link

ztane commented Jan 31, 2022

Looks like there is 17.0.0 for which there are prebuilt M1 binaries. But pip now refuses to install it because of the bad constraint in bip32
@doc-hex
Copy link

doc-hex commented Feb 14, 2022

I have same issue, except for me it's a system-installed coincurve 16.0.0 that I want

doc-hex added a commit to coinkite/python-bip32 that referenced this issue Feb 14, 2022
@doc-hex
Allow other major versions of coincurve
2323f04 
See <darosior#27>
@doc-hex doc-hex mentioned this issue Feb 14, 2022
Open
@darosior
Copy link
Owner

Hi, sorry i didn't see that earlier.

Yeah, i'm probably overly conservative with the coincurve version. Happy to take a PR relaxing the requirements, or i'll eventually get to it myself.

@doc-hex
Copy link

doc-hex commented Feb 15, 2022

I got you, PR is here: coinkite#1

@darosior
Copy link
Owner

Cool, can you PR to this repo?

@darosior darosior mentioned this issue Mar 9, 2022
Merged
@darosior
Copy link
Owner

darosior commented Mar 9, 2022 •
edited
Loading

Took a shot at this. I don't think we should allow any major version, as major versions may contain breaking changes.

@ztane @doc-hex can you have a look at #28 and let me know whether it fixes your issue? If it does i'll publish a new release.

@doc-hex
Copy link

doc-hex commented Mar 9, 2022

I think so, for my case.

@darosior
Copy link
Owner

Alright, merging #27 and releasing version 3.0 now. Please re-open if it is still an issue.

@darosior
Copy link
Owner

Linking #29 for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Coincurve versions up to 17 darosior/python-bip32
3 participants
@ztane @doc-hex @darosior