Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Message Events API with the new Events API #183

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jomargon
Copy link

@jomargon jomargon commented Jun 4, 2019

The Events API will be discontinued on October 1, 2019.

kirilsi and others added 3 commits May 9, 2016 12:02
Update from SparkPost/csharp-sparkpost master
The Events API will be discontinued on October 1. 2019.
@zythra
Copy link
Contributor

zythra commented Jun 10, 2019

@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes?

Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open.

If you'd like help just holler and I'd be happy to help plug them in.

@jomargon
Copy link
Author

@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes?

Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open.

If you'd like help just holler and I'd be happy to help plug them in.

We're using it in our projects and so far we haven't encountered any issues yet based on our use cases. I'll add the new MessageEventTypes tonight. Thanks for letting me know.

@zythra
Copy link
Contributor

zythra commented Jun 12, 2019

@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes?
Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open.
If you'd like help just holler and I'd be happy to help plug them in.

We're using it in our projects and so far we haven't encountered any issues yet based on our use cases. I'll add the new MessageEventTypes tonight. Thanks for letting me know.

Awesome, thanks!

I noticed there is also a value missing in the BounceClass enum (26, smart send suppression). I don't know how new that is, I hadn't noticed it in the API documentation until this morning.

Add InitialOpen, AmpClick, AmpOpen, AmpInitialOpen to MessageEventType

Add SmartSendSuppression to BounceClass
@jomargon
Copy link
Author

@zythra I've added the missing MessageEventType and BouncClass enum values

@zythra
Copy link
Contributor

zythra commented Jun 13, 2019

@jomargon Awesome, thanks for sharing your implementation!

Update from darrencauthon/csharp-sparkpost master
Copied branch from jomargon/csharp-sparkpost ISSUE-182 (Events API)
@kirilsi
Copy link
Contributor

kirilsi commented Sep 6, 2019

Great! Thank you, @jomargon!
Looks like pagination support is not implemented.
MessageEventsQuery.Page=10 (/api/v1/events/message?page=10) doesn't work any more (not supported).
https://developers.sparkpost.com/api/events/#events-pagination
We should use ListMessageEventsResponse.Links.Next URL to request next page, but I can't find a way to create request using custom URL.
I will implement it and publish soon.

@kirilsi
Copy link
Contributor

kirilsi commented Sep 9, 2019

I have implemented custom request URL support for Message Events API to be used for pagination.
Here is the pull request to ISSUE-182 branch:
jomargon#1

Added custom request URL support to Message Events API
@adamhathcock
Copy link
Collaborator

Any chance for an update of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants