-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Message Events API with the new Events API #183
base: master
Are you sure you want to change the base?
Conversation
Update from SparkPost/csharp-sparkpost master
The Events API will be discontinued on October 1. 2019.
@jomargon Excellent! I may grab your pull request to start testing with while we wait for Darren to merge. Have you had good success with your changes? Looks like there are new values that would need to be added to the MessageEventTypes enum. The types I notice at quick glance are initial_open, amp_click, amp_open, amp_initial_open. If you'd like help just holler and I'd be happy to help plug them in. |
We're using it in our projects and so far we haven't encountered any issues yet based on our use cases. I'll add the new MessageEventTypes tonight. Thanks for letting me know. |
Awesome, thanks! I noticed there is also a value missing in the BounceClass enum (26, smart send suppression). I don't know how new that is, I hadn't noticed it in the API documentation until this morning. |
Add InitialOpen, AmpClick, AmpOpen, AmpInitialOpen to MessageEventType Add SmartSendSuppression to BounceClass
@zythra I've added the missing MessageEventType and BouncClass enum values |
@jomargon Awesome, thanks for sharing your implementation! |
Update from darrencauthon/csharp-sparkpost master
Copied branch from jomargon/csharp-sparkpost ISSUE-182 (Events API)
Great! Thank you, @jomargon! |
… using Links.Next URL from the previous response.
I have implemented custom request URL support for Message Events API to be used for pagination. |
Added custom request URL support to Message Events API
Any chance for an update of this? |
The Events API will be discontinued on October 1, 2019.