Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: testing the (CSS) layout/appearance of HTML reports #935

Open
tylerjereddy opened this issue May 30, 2023 · 0 comments
Open

TST: testing the (CSS) layout/appearance of HTML reports #935

tylerjereddy opened this issue May 30, 2023 · 0 comments
Labels

Comments

@tylerjereddy
Copy link
Collaborator

In gh-927 I tried to convince the Argonne team, unsuccessfully, to add unit tests for the appearance (image grid-ordering) of the HTML reports produced by the python -m darshan summary .. code. The suitability of CSS in-browser rendering for unit testing has been debated more broadly in places like here: https://stackoverflow.com/questions/342579/css-unit-testing

In some of those discussions, CSS unit testing frameworks like https://github.com/jamesshore/quixote have been brought up.

I think the main argument against the testing is just the likely-large time investment needed. On the other hand, I'd much prefer to have unit tests enforce that common browsers are displaying what the team wants displayed instead of burdening i.e., scientific Python code reviewers with assessment of CSS layout interactions, and basically mandating more visual inspection on complex PRs since we can't trust the static HTML ordering to be what the browser renders as the CSS grows in complexity.

Another useful alternative may be to have a team member who is an expert at CSS/web design/layout testing deal with the code review aspects related to this, but this strikes me as unlikely anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant