Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for RPC #57

Open
platelk opened this issue Jul 31, 2015 · 5 comments
Open

Plugin for RPC #57

platelk opened this issue Jul 31, 2015 · 5 comments

Comments

@platelk
Copy link

platelk commented Jul 31, 2015

Hi,

After some times looking at RPC package, i didn't find any section about plugin or what is the recommended way to extends RPC as we can do in redstone here.

Why is want plugin ?

Because it think this is a nice way to extends the functionality of RPC and the annotation system can make it very clean, and easily reusable.

as example here i have create an authentication handler that allow me to check that the user is correctly authenticate before hitting the "/info/detail"

@IsAuth()
@app.Group("/account")
class AccountApi {
  AccountApi();

  @ToJson()
  @app.Route("/info/detail", methods: const[app.GET])
  getDetailInfo() {
    // ...
  }

So i didn't see equivalent in RPC, so is it possible to do the same thing in RPC or not ?
This kind of system would allow people to create mapper that can increasingly improve the experience of RPC.

@wibling
Copy link
Contributor

wibling commented Sep 17, 2015

That is a good point. @FaisalAbid is currently looking into adding plugins to the RPC package. It should be on its way.

@FaisalAbid
Copy link
Contributor

Yea it's on this way, sometime early next week I'll get a PR going.

@FaisalAbid
Copy link
Contributor

Update on this, been super busy with work, but it's coming!

@RdeWilde
Copy link

RdeWilde commented Apr 27, 2016

Can you push the WIP to a seperate branch maybe? @FaisalAbid

@rahulakash
Copy link

rahulakash commented Jul 21, 2016

@wibling @FaisalAbid : Is there any update on this? It would be really awesome to have the plugin support for RPC similar to Redstone Plugin API. This support will be a great add on for RPC moving forward. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants